"Any commit should be according to commit rules. And changes which do not actually affect how the code runs are actually unimportant from a core committer's point of view."
While it's actually hard to believe, I think the (very trivial) commit that was rejected broke the build for two reasons:
While it's actually hard to believe, I think the (very trivial) commit that was rejected broke the build for two reasons:
1) The project in question has a CLA requirement. https://github.com/joyent/libuv/blob/master/CONTRIBUTING.md#...
2) The project in question has a commit message policy that is CI-enforced. https://github.com/joyent/libuv/blob/master/CONTRIBUTING.md#...
Can anyone else confirm? I haven't seen this fact discussed publicly (although knowledgable people seem to allude to it).